use shards to automate setting of VERSION

luckyframework / lucky

A full-featured Crystal web framework that catches bugs for you, runs incredibly fast, and helps you write code that lasts.

https://luckyframework.org

MIT License

2.57k stars 156 forks source link

use shards to automate setting of VERSION #1690

Closed stakach closed 2 years ago

stakach commented 2 years ago

no more manual management of version constant

jwoertink commented 2 years ago

You know, I actually did this on LuckyEnv https://github.com/luckyframework/lucky_env/blob/7b10812688ec682fb86e9eeae640a63bc4500fd4/src/lucky_env.cr#L6 but I was curious as to whether this increases compile time or not... Since the Lucky ecosystem has so many shards, if they all did this, does that increase the compile time to a noticeable difference? Or is it like an extra 2ms for all of them?

stakach commented 2 years ago

I changed to using the macro to maintain compatibility with wyhaines/defined.cr Definitely not a noticeable difference in compile time, with multiple shards running this and OS caches still being hot the execution is extremely fast - although my dev laptop is a beast 😅