Allow setting the exec editor by env var. - Githubissues

luckyframework / lucky

A full-featured Crystal web framework that catches bugs for you, runs incredibly fast, and helps you write code that lasts.

https://luckyframework.org

MIT License

2.57k stars 156 forks source link

Allow setting the exec editor by env var. #1715

Closed jwoertink closed 1 year ago

jwoertink commented 1 year ago

Purpose

Fixes #1698

Description

This allows you to set your editor using an env var ENV["EDITOR"] when running exec.

Now you can set it 3 different ways:

# project widde
Lucky::Exec.configure do |settings|
  settings.editor = "mate"
end

# CLI arg
lucky exec -e mate

# ENV var
EDITOR=mate lucky exec

Checklist

[x] - An issue already exists detailing the issue/or feature request that this PR fixes
[x] - All specs are formatted with crystal tool format spec src
[x] - Inline documentation has been added and/or updated
[x] - Lucky builds on docker with ./script/setup
[x] - All builds and specs pass on docker with ./script/test