search

luckyframework / lucky

A full-featured Crystal web framework that catches bugs for you, runs incredibly fast, and helps you write code that lasts.
https://luckyframework.org
MIT License
2.57k stars 156 forks source link

Updating JS file causes lucky to recompile in 1.0.0-rc1 #1747

Closed jwoertink closed 1 year ago

jwoertink commented 1 year ago

After upgrading to 1.0.0-rc1, when I update any of my Vuejs files, lucky will now recompile. I think it's related to this change https://github.com/luckyframework/lucky/pull/1693

I'm still using laravel-mix in my, so nothing else has checked on the JS side. I'm using lucky watch --reload-browser

jwoertink commented 1 year ago

Using lucky watch seems to "fix" it... Also related: https://github.com/luckyframework/lucky/issues/1744

jwoertink commented 1 year ago

Turns out this comes from

https://github.com/luckyframework/lucky/blob/33e9d664605c41d09c29c072929393d7907d9505/tasks/watch.cr#L328-L334

which is telling the watcher to watch these files. I think this would be a good time to move them to the config/watch.yml as configurable watch directories.

Ref: https://github.com/luckyframework/lucky/issues/920

Then removing those bits fixes the issue.