search

luckyframework / lucky

A full-featured Crystal web framework that catches bugs for you, runs incredibly fast, and helps you write code that lasts.
https://luckyframework.org
MIT License
2.57k stars 156 forks source link

CI fails with missing ECR, so just adding a require just in case #1871

Closed jwoertink closed 2 months ago

jwoertink commented 2 months ago

Purpose

Fix this CI https://github.com/luckyframework/lucky_cli/actions/runs/8759728427/job/24044934376?pr=860#step:4:9633

Description

The e2e specs for LuckyCLI are failing with ECR missing. I don't know why, but hopefully adding these requires will fix it.

One thing to keep in mind is this comment https://github.com/crystal-lang/crystal/issues/14496#issuecomment-2058990690 I'm not sure how ECR plays in, but just in case something weird comes up....