luckyframework / lucky_flow

Automated browser tests for web applications. Similar to Ruby's Capybara.
https://luckyframework.github.io/lucky_flow/
MIT License
51 stars 8 forks source link

Separate tight integration with Selenium #135

Closed matthewmcgarvey closed 2 years ago

matthewmcgarvey commented 2 years ago

The goal is to get to #120 but in order to do that, we can't be so openly relying on the underlying selenium library because the in-memory browser won't be supplied through that library. This PR removes a BUNCH of places where we were either exposing Selenium objects, or directly relying on the selenium library for code not in the selenium driver. Before this, LuckyFlow::Driver was just a convenient way to create and access Selenium::Session. Now it is the core way lucky_flow interacts with the browser and the Chrome implementation does the interaction with selenium.

See #136 for more info