search

luckyframework / website-old

The old website for Lucky (archived)
https://github.com/luckyframework/website-v2
MIT License
11 stars 29 forks source link

Update guide with new patch and trace routing methods #168

Closed joeldrapper closed 5 years ago

joeldrapper commented 5 years ago

Bring the Acrtions and Routing guide up-to-date with the new routing methods introduced in luckyframework/lucky/pull/552.

edwardloveall commented 5 years ago

Awesome! Thanks for this. I think we'll wait to merge this until your PR is actually in a released version of Lucky so no one is trying to use these methods in the current version.

Please don't hesitate to remind me if I forget 😉

jwoertink commented 5 years ago

@edwardloveall ping 😉 this is merged

edwardloveall commented 5 years ago

Thanks for the reminder! I'll take a look at this tonight.

edwardloveall commented 5 years ago

Done! Congrats @joeldrapper and thanks for your contribution! 🎉

paulcsmith commented 5 years ago

Sorry I just noticed this! I think we may want to revert this. The commit is in Lucky master, but is not in an official release. So if someone tries to use this on v0.11 of Lucky it won't work.

Could we revert the commit and re-open the PR? Then we can merge it in once a new Lucky version is released

edwardloveall commented 5 years ago

Ah yeah, my bad. I even said "released version of Lucky" in my comment. Sorry about this @joeldrapper. We'll revert and re commit once this version of Lucky's released.