luckyframework / website-old

The old website for Lucky (archived)
https://github.com/luckyframework/website-v2
MIT License
11 stars 29 forks source link

Add mobile and tablet styles #181

Open sch opened 5 years ago

sch commented 5 years ago

I found myself wanting to read the docs on my phone, but I was having a hard time! This PR makes minimal changes to the existing styles and as few changes as possible to the existing markup to add responsive views into the guides.

Screenshots

Mobile:

Tablet:

Oddities

Some other things that should perhaps be addressed as a part of this feature:

jwoertink commented 5 years ago

I like this, and think it's pretty necessary. @sch, do you still have time to work on this? If so, can you rebase from master to pull in all the latest stuff?

sch commented 5 years ago

πŸ‘Just gave it a rebase. There are a few odd ducks from the new changes:

I'll take a shot at improving those this weekend.

jwoertink commented 5 years ago

The code blocks probably shouldn't wrap. Maybe just give them an overflow? Thanks for hopping back on this!