search

luckyframework / website-old

The old website for Lucky (archived)
https://github.com/luckyframework/website-v2
MIT License
11 stars 29 forks source link

Site updates #212

Closed jwoertink closed 5 years ago

jwoertink commented 5 years ago

I've added a footer because it's been bugging me for a while 😛 lol

Here's what it looks like:

screen shot 2019-03-06 at 8 53 49 pm

Nothing too fancy. Just a link to the code of conduct and social icons including the gitter chat. It needed something in the middle, so why not some love? 😄

2 main things not totally related though.

  1. I couldn't bundle on ruby 2.5.3 with eventmachine 1.2.2. I had to update that in order to boot middleman.
  2. The code samples had a margin-bottom pushing the footer down, so I got rid of it.
paulcsmith commented 5 years ago

Thanks for adding crystal to the code blocks. That is awesome 👍

Could you revert the event machine bump and put it in a separate branch? It seems like it is causing issues with the netlify deploy. It might be easier to debug separately so we can get this in the meantime

jwoertink commented 5 years ago

Yeah, I can't run bundle at all with that version. It blows up when building the Makefile for it. I'll send that as a separate PR