search

luckylwk / hoppin-design-system

Hoppin Design System (HDS)
https://design.gohoppin.com
1 stars 0 forks source link

fix: Fields / async-select should trigger onChange #17

Closed jonashaefele closed 4 years ago

jonashaefele commented 4 years ago

Closes #14 (at least it calls onChange properly and forwards the data from react-select) We might need to check if it saves/retrieves the right data from the DB, on the app side.

luckylwk commented 4 years ago

Doesn't work for some reason. The fields wrapper does not pickup the required field is populated.

image

I'll add some logging etc. later this morning and try to see what is not going where.

luckylwk commented 4 years ago

Leave it with me for now, its not worth you spending short amounts of time on this for now :)

jonashaefele commented 4 years ago

Weird it worked for me. Classic.

|| Sent from my phone

On Wed, 4 Dec 2019, 11:56 luckylwk, notifications@github.com wrote:

Doesn't work for some reason. The fields wrapper does not pickup the required field is populated.

[image: image] https://user-images.githubusercontent.com/6073340/70099545-16b39b00-15fd-11ea-8aab-3a8c54066c50.png

I'll add some logging etc. later this morning and try to see what is not going where.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/luckylwk/hoppin-design-system/pull/17?email_source=notifications&email_token=AAIZO6AOLIS65L4FITFT6UDQW6LHXA5CNFSM4JU24E62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF4YM4Q#issuecomment-561612402, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZO6G6FEHGYEL36PHB633QW6LHXANCNFSM4JU24E6Q .

luckylwk commented 4 years ago

Can you try something for me @jonashaefele :

Try confirming http://localhost:3000/booking/h/5da68d21ee15a5001c538b6a

This is a live booking (but on the dev. database obviously). If it works for you it has to do with my local version of the app/hds