search

luckylwk / hoppin-design-system

Hoppin Design System (HDS)
https://design.gohoppin.com
1 stars 0 forks source link

⏳ Bugfix: TextareaMd Placeholder #27

Closed luckylwk closed 3 years ago

luckylwk commented 4 years ago

@jonashaefele would love for you to have a look at this. A long placeholder in the TextareaMd overflows the editor. I tried to figure it out myself, by my css knowledge fails this test 🙈

image
jonashaefele commented 4 years ago

So seems like this is a known issue:

https://github.com/ianstormtaylor/slate/issues/2922

We pinned slate to a specific version to make it simple to use. But there have been HUGE updates to the library since.

Reading the issue on slate-js it seems like trying to fix the placeholder thing just adds other problems.

So I'd

jonashaefele commented 4 years ago

we pinned slate to v 0.45.1, it's currently on 0.57.1

It'll be a bit up an upgrade mess since the MD input field is made of quite a bit of stuff... but might be better than trying to hack this together.

luckylwk commented 4 years ago

we pinned slate to v 0.45.1, it's currently on 0.57.1

It'll be a bit up an upgrade mess since the MD input field is made of quite a bit of stuff... but might be better than trying to hack this together.

Let's revisit this next week, not important enough for now.

Added issue #28 in case we close the PR