search

luckylwk / hoppin-design-system

Hoppin Design System (HDS)
https://design.gohoppin.com
1 stars 0 forks source link

Luuk/orbiit surt font #62

Closed luckylwk closed 3 years ago

jonashaefele commented 3 years ago

I think it's a warning still, not an error, it still builds. But it showed up big and red in my console... Jonas

~ Jonas Haefele Founder of slow.works Coaching and consulting in mindful and sustainable tech. In order to focus on my work, I check emails twice a day and aim to respond the next day. In emergencies, please call +44 742 906 6868 ~

On Mon, 28 Sep 2020 at 14:26, luckylwk notifications@github.com wrote:

@luckylwk commented on this pull request.

In src/components/DesignProvider/DesignProvider.js https://github.com/luckylwk/hoppin-design-system/pull/62#discussion_r495937406 :

 text-align: left;

}

  • { color: inherit; } +
    • @font-face {

Oh interesting, I haven't seen it throw that yet, but will try it by updating Fonts

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/luckylwk/hoppin-design-system/pull/62#discussion_r495937406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZO6E4VVJHI7MV7YUDB43SICFJTANCNFSM4R4K3EEA .

jonashaefele commented 3 years ago

I can do a separate PR to harmonise font sizes again and check with the designs. Poppins and Surt render in different sizes.