Fixes: Custom API Auth headers in Paw + Postman Pathname Bug

luckymarmot / API-Flow

Universal data structure and converter for API formats (Swagger, RAML, Paw, Postman…)

MIT License

194 stars 24 forks source link

Fixes: Custom API Auth headers in Paw + Postman Pathname Bug #141

Closed JonathanMontane closed 6 years ago

JonathanMontane commented 7 years ago

Should fix https://github.com/luckymarmot/Paw-SwaggerImporter/issues/34

JonathanMontane commented 7 years ago

Should fix https://github.com/luckymarmot/Paw-PostmanCollectionV2Importer/issues/2

JonathanMontane commented 7 years ago

[x] fixes missing Postman imports in node, web and webworker
[x] normalizes Postman format names to postman-collection

JonathanMontane commented 7 years ago

[x] loaders now default to fsResolution instead of httpResolution in case of unknown protocol
[x] normalizes loaders behavior

caffeineflo commented 7 years ago

Hey @JonathanMontane,

thanks for getting back to me so quickly, I unfortunately wasn't that quickly testing your branch ... sorry!

Now that I finally got back to look into this, I tried reimporting the same Postman Collection again and I ended up getting a different error:

variable.createDynamicString is not a function. (In 'variable.createDynamicString()', 'variable.createDynamicString' is undefined)

JonathanMontane commented 7 years ago

@caffeineflo I'm looking into what may be causing this issue.

Are you by any chance using the noauth authentication type in your collection? This might be what is causing issues. I'm looking into how to fix this.

caffeineflo commented 7 years ago

@JonathanMontane No noauth in my collection.

What I've been wondering, are you using any kind of new API-Flow version that I don't have access to? I've been searching through the API-Flow source and your code is the only one that uses variable.createDynamicString hence I'm wondering if I'm missing a commit that defines createDynamicString

JonathanMontane commented 7 years ago

@caffeineflo createDynamicString is a method associated with variables that is exposed by Paw to the JS environment, which is why its definition is not inside the code (it's written in OBJ-C inside Paw).

I'll keep looking into what may be causing this bug then.

caffeineflo commented 7 years ago

Hey @JonathanMontane ,

I was wondering if there's anything I can do to help you debug this issue from my side?

mittsh commented 6 years ago

@caffeineflo FYI I have fixed the bug in PR #143, I'll release a new Postman Importer and Swagger Importer shortly.