search

luckyrat / KeePass-Favicon-Downloader

A KeePass plugin that downloads and stores favicons. A favicon is the little icon / logo used to identify many websites, typically displayed in the browser's address bar, bookmark list and on tabs.
70 stars 19 forks source link

ubuntu package #11

Open darkdragon-001 opened 10 years ago

darkdragon-001 commented 10 years ago

It would be nice if you would automatically generate a .deb package when building for easier installation in Ubuntu.

Please note that it should require "keepass2" and "mono-complete"!

tengwar commented 10 years ago

So this extension does work on Linux? I thought it doesn't; it didn't for me.

darkdragon-001 commented 10 years ago

@tengwar Just install the package mono-complete ;)

tengwar commented 10 years ago

@darkdragon-001 Dude, thanks! :)

luckyrat commented 10 years ago

I won't be doing this myself in the foreseeable future.

I suspect this is something that can be managed by someone else (in a similar way to the ubuntu package for KeeFox) but I don't know enough about what is involved to say for sure.

I'm happy for someone else to announce a 3rd party package here or submit a pull request that will automatically generate the package from the existing visual studio build process. I don't know enough about deb packages to know if that can be done in a standard windows build environment.

darkdragon-001 commented 9 years ago

I tried to get the Linux version working. But for some reason, it doesn't accept my generated .plgx file.

In order to generate it, I copy HtmlAgilityPack.dll, KeePassFaviconDownloader.csproj and Properties/AssemblyInfo.cs to a temporary folder and then run mono /usr/lib/keepass2/KeePass.exe --plgx-create TMP_DIR to create the plugin file.

When starting KeePass 2, I get the error "The following plugin is incompatible with the current KeePass version".

When I use the .plgx provided on your website or my self compiled .dll, everything works fine.

NOTE: See build.sh in my fork.

darkdragon-001 commented 7 years ago

I got things working in my fork.

Only some meta files need to be improved by stylistic means. Can someone with Debian package experience have a look, please?

darkdragon-001 commented 7 years ago

I did some more changes and it should now be almost ready: See my pre-release.

Can someone please review?

darkdragon-001 commented 7 years ago

With a small change to dlech/KeePass2.x#4, it is now even possible to create the Debian package from Ubuntu shell within Windows 10!

darkdragon-001 commented 5 years ago

@darkdragon-001 I've been looking at making a new release soon and since I'm now primarily using Linux rather than Windows, that's a bit of a blocker since I doubt I'll have time to re-work everything from the current master into a state that I can build without Visual Studio.

From the looks of it, you have a working fork that has already solved this problem (and some others too if my brief look over your commit titles are anything to go by). Do you think your fork is in or close to being in a state where you could put in a PR to the master branch in this repo?

Being completely ignorant of what's required to build deb files and/or any type of linux package publishing, how would you see that working if I accept a PR containing your changes?

I can obviously add you as a collaborator on this repo if that'll make things easier?

@luckyrat I changed the folder structure so that I can directly package the sources as.kdbx instead of copying them to a temporary location. I changed some output paths (but couldn't test it on Windows). Here some decisions should be made where which (temporary) output files should be placed (I am looking for any feedback here). Further, I added nuget auto-download to the Makefile (maybe the version from the repos is to old and it must upgrade itself - I can't find the corresponding issue at the moment though).

I probably won't have a lot of time for this change in the coming months, but would like to help. In the meantime, you can check out my fork. Just run make for Release (.kdbx) or make -f MakefileDebug for Debug (.dll). The KeePass console bug was fixed in KeePass 2.41. In order to build the .deb packages, I added some notes to the README.md file at the bottom.