search

luckyrat / KeePass-Favicon-Downloader

A KeePass plugin that downloads and stores favicons. A favicon is the little icon / logo used to identify many websites, typically displayed in the browser's address bar, bookmark list and on tabs.
70 stars 19 forks source link

SSL certificate errors #16

Open maneamarius opened 7 years ago

maneamarius commented 7 years ago

Hi,

I'm having issues with the plugin on Gentoo Linux.. it complains about SSL certificate errors. Is it possible to ignore the certificate errors?

Something like this should do it: -- insert this on line 450 in file KeePassFaviconDownloaderExt.cs ((HttpWebRequest)webreq).ServerCertificateValidationCallback += (sender, certificate, chain, sslPolicyErrors) => true;

If not too much to ask, could you please test it works and make this change?

thanks a lot, Marius

darkdragon-001 commented 5 years ago

One should not just ignore/circumvent certificate issues!

Anyways, I used IOConnection API from KeePass to obey system-wide settings. Then certificate checking can be disabled via Tools > Options > Advanced > File Input/Output Connections > Uncheck Accept invalid SSL certificates (self-signed, expired, ...). Just run make on Linux to create a plgx. This can then be used under all OSes.

Note that this patch is work in progress and needs some more testing, exception handling and so on.