search

luckyrat / KeePass-Favicon-Downloader

A KeePass plugin that downloads and stores favicons. A favicon is the little icon / logo used to identify many websites, typically displayed in the browser's address bar, bookmark list and on tabs.
70 stars 19 forks source link

Switch to asynchronuous mode operation #2

Closed DarkWanderer closed 9 years ago

DarkWanderer commented 11 years ago

Switched download task to a BackgroundWorker instance. Now with smooth and beautiful progress bar™ and working cancel button™

luckyrat commented 10 years ago

It would be cool to incorporate these changes into KeePass Favicon Downloader v 1.8 but github was not able to merge your pull request at the moment. I think we both made changes to the same parts of the plugin and there is something odd about the way github thinks the entire file changed when you committed "Corrected a typo in the comment (test commit)".

I've manually applied the "protection from cyclic redirects" in v 1.7.2 but I think I'll need a slightly neater pull request before I can work out how to incorporate your other changes.

I don't understand github pull requests enough to know if we should try to re-use this same pull request or not so I'll leave it open for the time being.