search

luckyrat / KeePass-Favicon-Downloader

A KeePass plugin that downloads and stores favicons. A favicon is the little icon / logo used to identify many websites, typically displayed in the browser's address bar, bookmark list and on tabs.
70 stars 19 forks source link

SecureChannelFailure: The request was aborted #20

Open haidelber opened 5 years ago

haidelber commented 5 years ago

It seems this plugin (System.Net.WebRequest) uses TLS 1.0 to connect to download Favicons. As TLS 1.0 is vulnerable it's disabled on many webservers (https://www.globalsign.com/en/blog/disable-tls-10-and-all-ssl-versions/). This is the reason for the majority of my new entries not being able to download favicons which is a bit annoying. As MS docs suggests System.Net.Http.HttpClient should be used now but this is only available from .Net 4.5. Would you accept a pull request lifting the .Net framework requirement to 4.5 or should I rather fork?

haidelber commented 5 years ago

It seems it can be fixed by setting the TLS version manually as well: https://support.microsoft.com/en-gb/help/3154517/support-for-tls-system-default-versions-included-in-the-net-framework#section-2