search

luckyrat / KeePass-Favicon-Downloader

A KeePass plugin that downloads and stores favicons. A favicon is the little icon / logo used to identify many websites, typically displayed in the browser's address bar, bookmark list and on tabs.
70 stars 19 forks source link

Fixes SecureChannelFailure #21

Open haidelber opened 5 years ago

haidelber commented 5 years ago

see Issue #20

haidelber commented 5 years ago

I guess the changes should be fine now. Splitted everything up in a few commits.

luckyrat commented 5 years ago

Thanks. LGTM now.

I'm holding off the merge for a bit pending the resolution of discussion around the best way to enable me to build and test on Linux (rather than Windows Visual Studio when I last did made a release). See #12

darkdragon-001 commented 4 years ago

This is already been dealt with by my change to use KeePassLib.Serialization.IOConnection for downloading files as it can be seen in KeePassLib/Serialization/IOConnection.cs#L506.

qeerl commented 2 years ago

I'm not a coder, but when a new release will fix this SecureChannelFailure? No way to download favicons from a lot of websites. Examples: github.com, sourceforge.net (with Windows)

That's a great plugin, thanks for it, but the last release is from 2014 and the issue has been widely reported. I don't get it...

luckyrat commented 2 years ago

Please see this new post on the KeePass forum: https://sourceforge.net/p/keepass/discussion/329220/thread/9a54032510/

I wanted to post it there to ensure the full range of current and potential users of this plugin can read and respond to it.

qeerl commented 2 years ago

Thank you for the clarification ! I should have searched for alternatives, it was not hard to find...

This one works perfectly on Windows:

https://github.com/navossoc/KeePass-Yet-Another-Favicon-Downloader