Fix favicon parsing in case when there is many <link rel="shortcut icon"> nodes in page

luckyrat / KeePass-Favicon-Downloader

A KeePass plugin that downloads and stores favicons. A favicon is the little icon / logo used to identify many websites, typically displayed in the browser's address bar, bookmark list and on tabs.

70 stars 19 forks source link

Fix favicon parsing in case when there is many <link rel="shortcut icon"> nodes in page #9

Closed alt-grr closed 9 years ago

alt-grr commented 9 years ago

Test case: http://forum.notebookreview.com/

luckyrat commented 9 years ago

Looks good, thanks. Out of interest, is there an official spec that says web browsers must always use the last link[@rel] node or just a convention you've noticed?

alt-grr commented 9 years ago

I think it's just a convention: browser parses nodes and writes them to tree; when duplicated node is encountered, and only single node of that type is allowed, it overwrites previously saved value.