search

lucmartens / xstate-plantuml

Visualize a xstate or react-automata statechart as a plantuml state diagram
MIT License
71 stars 10 forks source link

How about support for xstate@4? #43

Open karfau opened 4 years ago

karfau commented 4 years ago

While trying to add a test for #40 I realized that the state machine I describe in #38 is not valid vor xstate@3 but only for v4.

Updating to version 4 makes the download test fail with a message that I fixed in one of the recent PRs.

If we still want to support both version 3 and 4 we could at least start a xstate@4 branch to start working on it (and release them as prereleases?). Or maybe there is a way to test against both version 3 and 4 on CI, any ideas? (Just updating as part of CI might not work since not all machines work for both versions.)

I think for the users they will only have machines for one version, so they don't have that issue.

karfau commented 4 years ago

As you can see I added a POC to solve that issue to #40 . I can easily extract those changes into different PRs if you want. Please let me know what you think. (My inspiration was this article: https://dev.to/joshx/test-your-npm-package-against-multiple-versions-of-its-peer-dependency-34j4 )

karfau commented 3 years ago

FYI: since there was no response in this repo since I created the issue and PRs, I have now decided to focus on maintaining my fork. This leads to the fact that the branches are starting to contain more things then makes sense in this repository.