search

lucmoreau / ProvToolbox

Java toolkit to create and convert W3C PROV data model representations, and build provenance-enabled applications in a variety of programming languages (java, python, typescript, javascript)
Other
75 stars 42 forks source link

parsing attributes in provn #111

Closed dtm closed 9 years ago

dtm commented 9 years ago

The provn parser accepts a document in which an attribute list is missing either or both of their [ ] characters. Eg

document prefix ex http://example.com/ entity(ex:a, ex:b='ex:c') endDocument

It does warn, however.

lucmoreau commented 9 years ago

Test case:

curl https://gist.githubusercontent.com/lucmoreau/056a7caeef23f1d8f65c/raw/402760acbd5544983540896c70364a79933e631e/gistfile1.txt | provconvert -infile - -informat provn -outfile - -outformat provn
lucmoreau commented 9 years ago

The following commit redirects the parser warnings to the log4j logging infrastructure.

https://github.com/lucmoreau/ProvToolbox/commit/71f8acccad1f1810af75a66e3e6f049873205f3d

lucmoreau commented 9 years ago

The question is whether does should be a warning or whether it should be a fatal reporting?

lucmoreau commented 9 years ago

Created a new issue to handle strict mode. https://github.com/lucmoreau/ProvToolbox/issues/137