lucmos / UltrawideWindows

KWin script to move windows quickly
https://store.kde.org/p/1276605/
GNU General Public License v2.0
195 stars 39 forks source link

Move to right-height 4x2 uses 2 slots instead of one #8

Closed sharhalakis closed 4 years ago

sharhalakis commented 4 years ago

Ctrl+Meta+Num+6 uses 2/4 horizontal slots instead of 1/4.

Can you please update the code to use 1?

I.e. this:

registerShortcut("MoveWindowToRightHeight4x2_centerbiased", "UltrawideWindows: Move Window to right-height (4x2 center biased)", "Ctrl+Meta+Num+6", function () {
    move(workspace, 4, 1, 3, 0, 2, 1)
});

needs to have move(workspace, 4, 1, 3, 0, 1, 1)

lucmos commented 4 years ago

Hi,

If I'm not mistaken on master I already fixed it in https://github.com/lucmos/UltrawideWindows/commit/10bc8d02178503302070dd884e1e01d5390046f4

https://github.com/lucmos/UltrawideWindows/blob/10bc8d02178503302070dd884e1e01d5390046f4/contents/code/main.js#L171-L172

sharhalakis commented 4 years ago

Great! In that case this is then a request to push a new version to store.kde.org :)

lucmos commented 4 years ago

Ok, I bumped the version and published it on the store!