About the TabBar hide, feel you judge some mistakes.

lucoceano / Pager

Pager is the simplest and best way to implement sliding view controllers in Swift

MIT License

232 stars 41 forks source link

About the TabBar hide, feel you judge some mistakes. #31

Closed ChildrenGreens closed 7 years ago

ChildrenGreens commented 7 years ago

if self.tabBarController != nil && self.tabBarController?.tabBar.isTranslucent == true { frame.size.height -= self.tabBarController!.tabBar.frame.height }

Modified into

if self.tabBarController != nil && self.tabBarController?.tabBar.isTranslucent == false { frame.size.height -= self.tabBarController!.tabBar.frame.height }

lfarah commented 7 years ago

@duanyicanyuan can you open a PR explaining about the improvement?