lucymei / STAT545-hw-Mei-Lucy

0 stars 0 forks source link

hw05 is ready for grading #5

Open lucymei opened 6 years ago

lucymei commented 6 years ago

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho The link to hw05 is here. My main homework page is here. Thank you!

cheungamanda commented 6 years ago

Hi Lucy, Excellent work! Here's my review for homework 05:

Coding style: + Clear and organized, easy to follow along! Each step was explained and well formatted throughout!

Coding strategy: + Simple and efficient, logical flow of code, complex code is broken down, great use of piping! If you load the forcats package, you can just write the function fct_reorder() as opposed to forcats::fct_reorder()! Your variable names were clear and did not cause confusion.

Presentation - graphs: + Great job exploring the various visualization features! I loved your life expectancy overtime plot, especially with the different colours comparing high and low life expectancy. I definitely didn't know you could do that, so I'll definitely be incorporating this feature into my work!

Presentation - tables: 0 I would use kable() to present the various tables you've shown!

Achievement, mastery, cleverness, creativity: + Excellent application of tools and techniques! Great job experimenting with writing and reading files. I like your approach for writing figures to files. I learned that you could combine plots together, thank you!

Ease of access for instructor, compliance with course conventions for submitted work: + Easy access, code runs!

Thanks, Amanda

ksedivyhaley commented 6 years ago

Factor management (drop & reorder): Yes File I/O (data): Yes Visualization design: Yes File I/O (write figure): Yes Organized GitHub: OK (see comments) Bonus (more forcats, eg revalue): Attempted Reflection: Yes

Comments:

Your mark will be distributed later. If you would like more feedback, please feel free to message me on slack.