lucyparsons / OpenOversight

Police oversight and accountability through public data 👮
https://openoversight.com
GNU General Public License v3.0
240 stars 79 forks source link

Re-add SMTP email provider #1047

Closed sea-kelp closed 1 year ago

sea-kelp commented 1 year ago

Description of Changes

The current EmailClient class only supports sending emails from a GSuite email account.

This change allows OpenOversight to auto-detect which email implementation to use (Google, SMTP, or Simulated) based on which of the following is configured:

Notes for Deployment

Screenshots (if appropriate)

Tests and linting

sea-kelp commented 1 year ago

@michplunkett - I just tested these changes using SMTP. Would you mind testing with a Google Workspace account?

1

michplunkett commented 1 year ago

Some small nits here and there, but it otherwise looks great! I'll do some testing on it Monday afternoon and stamp this bb with an 'Approved' afterward!

michplunkett commented 1 year ago

Tested with GSuite and made the appropriate changes. Provided you're happy with it, @sea-kelp, it's good to merge!

sea-kelp commented 1 year ago

@michplunkett Thanks for the changes! Please do merge this PR when you get a chance