Closed sea-kelp closed 1 year ago
@michplunkett - I just tested these changes using SMTP. Would you mind testing with a Google Workspace account?
Some small nits here and there, but it otherwise looks great! I'll do some testing on it Monday afternoon and stamp this bb with an 'Approved' afterward!
Tested with GSuite and made the appropriate changes. Provided you're happy with it, @sea-kelp, it's good to merge!
@michplunkett Thanks for the changes! Please do merge this PR when you get a chance
Description of Changes
The current
EmailClient
class only supports sending emails from a GSuite email account.This change allows OpenOversight to auto-detect which email implementation to use (Google, SMTP, or Simulated) based on which of the following is configured:
service_account_key.json
file exists and is non-emptyMAIL_SERVER
andMAIL_PORT
are setNotes for Deployment
Screenshots (if appropriate)
Tests and linting
develop
branch.pytest
passes on my local development environment.pre-commit
passes on my local development environment.