Address edit `Department` error

lucyparsons / OpenOversight

Police oversight and accountability through public data 👮

https://openoversight.com

GNU General Public License v3.0

240 stars 79 forks source link

Address edit `Department` error #1048

Closed michplunkett closed 1 year ago

michplunkett commented 1 year ago

Description of Changes

I removed the created_by field from the from on editing a Department.

Tests and linting

[x] This branch is up-to-date with the develop branch.
[x] pytest passes on my local development environment.
[x] pre-commit passes on my local development environment.

sea-kelp commented 1 year ago

Would you mind adding a test for this? I definitely would have expected one of our tests to have picked this up

michplunkett commented 1 year ago

Which error specifically? I checked the behavior of the app manually and via tests, and couldn't find the bug. It ends up that's because it wasn't a bug in the current version, but one that was fixed in one of the last 5 PRs.

michplunkett commented 1 year ago

Can you recheck this PR when you get a chance, @sea-kelp?