lucyparsons / OpenOversight

Police oversight and accountability through public data 👮
https://openoversight.com
GNU General Public License v3.0
240 stars 79 forks source link

Address Coveralls bug #1100

Closed michplunkett closed 5 months ago

michplunkett commented 6 months ago

Fixes issue

https://github.com/lucyparsons/OpenOversight/issues/1099

Description of Changes

Fixing the Coveralls upload bug.

Tests and Linting

Screenshot 2024-06-03 at 4 51 04 PM
michplunkett commented 5 months ago

Could you take a look at this build, @sea-kelp, and tell me if anything looks obviously wrong: https://github.com/lucyparsons/OpenOversight/actions/runs/9335574698/job/25695125327?pr=1100

It's linked to this PR: https://github.com/lucyparsons/OpenOversight/pull/1082

I'm also seeing that the branches have not been updated on here since April 17th: https://coveralls.io/github/lucyparsons/OpenOversight

sea-kelp commented 5 months ago

@michplunkett fixed - I think what happened is that the coverage file was being created by docker when setting up the bind mount, which gave it weird permissions.

I haven't dug into the linked PR so not sure why that change in particular broke this workflow

Can you check that the coverage has been uploaded successfully?

michplunkett commented 5 months ago

I'll take a look! I tried doing that from the Docker side, but it didn't seem to work: https://github.com/lucyparsons/OpenOversight/pull/1100/commits/f19fc87cfb2ea447a64358bc82e98d58001c6109

Good find, @sea-kelp! I'll check it out.

michplunkett commented 5 months ago

Looks good to me!

Screenshot 2024-06-03 at 4 06 02 PM

https://coveralls.io/builds/67861750

sea-kelp commented 5 months ago

I'll take a look! I tried doing that from the Docker side, but it didn't seem to work: f19fc87

Good find, @sea-kelp! I'll check it out.

The file is mounted from the host machine onto the container filesystem, so the file would need to be created on the host side https://docs.docker.com/storage/bind-mounts/