Closed michplunkett closed 5 months ago
Could you take a look at this build, @sea-kelp, and tell me if anything looks obviously wrong: https://github.com/lucyparsons/OpenOversight/actions/runs/9335574698/job/25695125327?pr=1100
It's linked to this PR: https://github.com/lucyparsons/OpenOversight/pull/1082
I'm also seeing that the branches have not been updated on here since April 17th: https://coveralls.io/github/lucyparsons/OpenOversight
@michplunkett fixed - I think what happened is that the coverage file was being created by docker when setting up the bind mount, which gave it weird permissions.
I haven't dug into the linked PR so not sure why that change in particular broke this workflow
Can you check that the coverage has been uploaded successfully?
I'll take a look! I tried doing that from the Docker side, but it didn't seem to work: https://github.com/lucyparsons/OpenOversight/pull/1100/commits/f19fc87cfb2ea447a64358bc82e98d58001c6109
Good find, @sea-kelp! I'll check it out.
Looks good to me!
I'll take a look! I tried doing that from the Docker side, but it didn't seem to work: f19fc87
Good find, @sea-kelp! I'll check it out.
The file is mounted from the host machine onto the container filesystem, so the file would need to be created on the host side https://docs.docker.com/storage/bind-mounts/
Fixes issue
https://github.com/lucyparsons/OpenOversight/issues/1099
Description of Changes
Fixing the Coveralls upload bug.
Tests and Linting
develop
branch.pytest
passes on my local development environment.pre-commit
passes on my local development environment.