search

lucyparsons / OpenOversight

Police oversight and accountability through public data 👮
https://openoversight.com
GNU General Public License v3.0
240 stars 79 forks source link

create unit view of officers #733

Closed redshiftzero closed 4 years ago

redshiftzero commented 4 years ago

We have a way to create units via the web UI, but not an easy way to - for a given unit - see which cops are assigned to it, along with any other information stored about the unit.

This should be viewable by non-logged in users.

fritzdavenport commented 4 years ago

Looking to get started on this. Question, though, doesn't look like units have officers in the db schema? https://disman.tl/oo-docs/tables/departments.html

edit:// ah, okay. assignment has unit and officer. I'll pull those

brianmwaters commented 4 years ago

@dismantl i didn't even know you were hosting these docs. How up to date are they?

dismantl commented 4 years ago

oh sorry those docs are ages out of date, I forgot they were still online. They were generated using schemaspy when I wanted to get a visualization of the db schema. If that's helpful for others I could submit a PR to add a Makefile target to autogenerate those docs from a dev environment, kinda like this.

fritzdavenport commented 4 years ago

@brianmwaters @dismantl no worries on it. There's also an image of the schema in the repo - dunno if that's up to date either :) I poked around in the dev db, though, and verified what I needed (and will be adding a make target to get onto the docker-compose db in my PR)

brianmwaters commented 4 years ago

@fritzdavenport you can also check out https://github.com/lucyparsons/OpenOversight/blob/develop/OpenOversight/app/models.py, or use a tool like psql to connect to the database locally, after running make start. The creds are in https://github.com/lucyparsons/OpenOversight/blob/develop/docker-compose.yml.

fritzdavenport commented 4 years ago

Thanks @brianmwaters :+1: PR incoming, for whoever is ready for it