search

lucyydotp / GivePet

Transfer ownership of your pets to other people
2 stars 0 forks source link

Can't /givepet foxes #1

Open hahaluckyme opened 3 years ago

hahaluckyme commented 3 years ago

Couldn't use /givepet to gift a baby fox, and discovered it's not part of Tameable? https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Tameable.html

Transfer attempt fails here: https://github.com/lucyy-mc/GivePet/blob/master/src/main/java/me/lucyy/givepet/InteractListener.java#L33

Not sure if it should be included but thought I'd open an issue for it.

lucyydotp commented 3 years ago

Ah somehow i missed this issue, my bad. Foxes do behave a little differently to most tameable entities so this could be a little interesting (they have two "trusted players" https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Fox.html) but I'll come up with something.

lucyydotp commented 1 year ago

it's been a little while oopsie :D

Is this still an issue? I'm rewriting most of the code anyway so I could add support in while I'm here

hahaluckyme commented 1 year ago

Not sure! I don't even play on that server anymore and the new one I play on isn't using this plugin since /givepet is included in GriefDefender now. I don't mind if you close it :o