search

ludbb / secp256k1-py

Python FFI bindings for secp256k1 :dizzy:
MIT License
107 stars 53 forks source link

expose privkey_tweak_add and pubkey_tweak_mul functions from lib #2

Closed AdamISZ closed 8 years ago

AdamISZ commented 8 years ago

See #1

ludbb commented 8 years ago

It seems some assumptions were invalidated in the latest libsecp256k1, which resulted in this build failure.

Aside from that, would be against naming these functions as tweak_mul, tweak_add and add both of them to PrivateKey and PublicKey? That would be more inline with other functions.

AdamISZ commented 8 years ago

Renaming: of course, no problem. Adding others: for adding pubkeys there is already combine(), right? For privkey_tweak_mul; sure, haven't really thought about it - didn't have a need for it myself.

ludbb commented 8 years ago

Yes, PublicKey.combine is there already.

ludbb commented 8 years ago

Let me know if you're planning to send an updated PR with these changes, thanks.

AdamISZ commented 8 years ago

Hi, sure, but I was just going to ask you: should I wait until the build is fixed? Otherwise I'll just resubmit with the names changed, is that OK?

ludbb commented 8 years ago

Since that comment the build has been fixed and the newer sig compact serialization functions and sig normalized have been exposed. IOW: the build is fine, please proceed :)

g-p-g commented 8 years ago

??

g-p-g commented 8 years ago

I'm also interested on this, is it being closed for a new PR or should I do it?

AdamISZ commented 8 years ago

Gimme a second :) Yes, new PR.