ludeknovy / jtl-reporter

JtlReporter is an online application that allows users to generate beautiful, customizable and easy to understand performance reports from JMeter(Taurus), Locust, and other tools.
https://jtlreporter.site
MIT License
127 stars 33 forks source link

Support for Active Directory / SSO #67

Open kierangirvan opened 3 years ago

kierangirvan commented 3 years ago

Describe the solution you'd like We would like to manage access to jtlreporter via our company active directory, rather than having to manage user access separately, is this something you hope to support in the future?

ludeknovy commented 3 years ago

Hi @kierangirvan I definitely wont give you any estimation on it as I have to look what does it take to create AD integrations first. But I see the use case, and it make sense.

Btw. if you want to share the report with someone without the credentials, you can create new share link in a report detail, that will allow "read-only" access to the report without the credentials. In the past I was considering "read-only" mode as grafana has.

kierangirvan commented 3 years ago

Thanks @ludeknovy - thats interesting reading the read-only view, we may opt for this approach for now, and hopefully later down the line introduce the active directory integration when its supported.

Shall I leave this feature request open for now? Or is there a preferred place for me to raise this?

ludeknovy commented 3 years ago

@kierangirvan lets leave this ticket open ;)

kierangirvan commented 1 year ago

@ludeknovy out of interest are you still considering this? We would hugely benefit in having SSO via github auth.

ludeknovy commented 1 year ago

@kierangirvan yeah, I still consider it, but no active development so far.

kierangirvan commented 11 months ago

Hey @ludeknovy I've been chased whether this might be possible in the near future?

ludeknovy commented 11 months ago

Hi @kierangirvan ! I am not sure about the near future. It looks like you are the only one who is interested in this feature, and it will require significant effort to get it implemented. For this reason, I give more priority to the other features/issues.

milanpanik commented 10 months ago

+1 for the AD / SSO integration. We are using your tool in our company and have users in AD, so it would be really nice to integrate it together

kierangirvan commented 3 months ago

@ludeknovy I've recently started with 2 different clients and pushing JTL reporter as an alternative for licensed products, the biggest sticking point we're having issue SSO integration. If this is something that can be supported I think we can push even further.

ludeknovy commented 3 months ago

Hi @kierangirvan ! Thanks for reaching out. This is definitely not a trivial feature to implement. Would you be willing to work on a MR for this one? For me it means running the AD somewhere, exploring the libraries for it, integrate it - and make adjustments to the current code if needed.

Btw. what are those licensed products?