ludens-reklamebyra / react-crisscross

Flexible Layout Component for React
MIT License
2 stars 0 forks source link

The lib should keep styled components out of the bundle #63

Open oyvindhermansen opened 6 years ago

oyvindhermansen commented 6 years ago

Describe the bug The people behind styled-components have a section about: Should I bundle styled-components with my library?

Their recommendation is to not bundle it with any npm library.

Quote from the website:

Adding styled-components to peerDependencies will signal your library consumers that styled-components is not included with the library and they need to install it themselves.

So by posting this issue I want to see a section in the documentation that informs exactly what the quote above says.

Expected behavior A clear and concise text of having to install styled-components in order to use React crisscross.

Screenshots

skjermbilde 2018-08-03 kl 23 06 07

Additional context Source of information: https://www.styled-components.com/docs/faqs#i-am-a-library-author-should-i-bundle-styledcomponents-with-my-library