search

ludiazv / octocitrico

OctoPrint for other fruits
148 stars 19 forks source link

How to configure individuell overlays #31

Open volkmarnissen opened 1 year ago

volkmarnissen commented 1 year ago

Hi,

I am building an image for opizero. I'd like to use the additional USB hosts. So, I need to add overlays usbhost1 and usbhost2. Usually this happens in extra.sh for the board. I'll do the changes in my fork. However, does it make sense to pull it into master branch?

This makes it easier to support USB cameras.

ludiazv commented 1 year ago

I think for opizero usb is enabled. Any how if you find any improvement please send over a pull request that will be included in the next release.

volkmarnissen commented 1 year ago

Hi,

you are right. However, I also like to use pwm for LED control.

The manifest file is somehow matching perfectly for anycubic ... printers. I am using prusa MK3. Prusa MK3 has no built in LED, but has mesh bed leveling in the firmware. I have no idea how to implement it, but may be it makes sense to have a configurable manifest to support different printers. However, If no one else has this issue, we can leave it as it is. For other issues, I created fixes and a pull request. However, thank you for providing the image builds. They make it a lot easier to run octoprint on armbian based hardware.

ludiazv commented 1 year ago

Hi, Thank you for your contributions.

I've never worked with pwm in the opi zero. I did not added by default it conflicts with UART0 / console. If you want to enable is simple. Go to extra.sh and add one overlay like this: https://github.com/ludiazv/octocitrico/blob/37ef18035e4311142171ee5e6243f6a45af4d2e4/boards/opizero/extra.sh#L20

For the pull request, thanks for the contribution. I've revived it and I will not merge it yet as it links the build to a specific commit in the dev tree of octopi. I prefer to link with stable versions published upstream to avoid including any unstable version that might create bugs difficult to trace.

OctoPi will release soon a new version 1.0.0. (new in Rc3) Then I will implement your pull request with some minor changes to be inline with new octopi version.

Thanks again for your help in the project.