search

ludlows / PESQ

PESQ (Perceptual Evaluation of Speech Quality) Wrapper for Python Users (narrow band and wide band)
https://github.com/ludlows/PESQ
MIT License
518 stars 97 forks source link

Hi #32

Closed quancs closed 3 years ago

quancs commented 3 years ago

王老师，您好，打扰了。 您的这个pesq包做得非常的好，是pesq包里面封装得最好的，目前我也正在使用使用您的包。 现在我遇到的问题就是，如果需要使用pesq的话，我需要自己再进行一次封装，来使得pesq可以适应pytorch-lightning这个框架。 因此，希望您将pesq搬到TorchMetrics，不知您是否有时间！

ludlows commented 3 years ago

thanks for your suggestion. I am ok to help. But I have seen your pull request for adding pesq into TorchMetrics. Actually you can continue this work.

quancs commented 3 years ago

Em... Yeah, I have given a pull request... But my pull request uses pesq as a dependency, which will make the TorchMetric more and more complicated when more metrics are implemented. Thus, it would be better that you can integrate the source code of pesq into TorchMetric.

ludlows commented 3 years ago

@quancs thanks for your reply. do you mean that I need to inject the c source code of pesq into TorchMetric ?

ludlows commented 3 years ago

please reopen it if you wanna discuss more

quancs commented 3 years ago

@quancs thanks for your reply. do you mean that I need to inject the c source code of pesq into TorchMetric ?

@ludlows Yeah... Are you willing to do this job? It's OK if not.