search

ludo / react-native-torch

Torch (flashlight) plugin for React Native (Android/iOS)
MIT License
78 stars 27 forks source link

Android Build Release: error failed linking resources #14

Open rjx444 opened 5 years ago

rjx444 commented 5 years ago

Hi,

Currently I can't build my app successfully due to the error that appears when building a release apk for android. Have you guys manage to trigger this issue too and had a fix to it?

Here is my current react native version being used: "react": "16.6.1", "react-native": "0.57.7"

Thanks, Raymond

fredrik-jarnbrost commented 5 years ago

I had this problem, solved it by setting compiledSdkVersion to 28 in node_modules/react-native-torch/android/build.gradle

It seems fixed here: https://github.com/ludo/react-native-torch/commit/5d412d0c4d52c7ecfd5260c28c100a2d6da50f47#diff-7ae5a9093507568eabbf35c3b0665732

But that is not what I get on npm install so 🤷‍♂

ridvanaltun commented 5 years ago

I had this problem, solved it by setting compiledSdkVersion to 28 in node_modules/react-native-torch/android/build.gradle

It seems fixed here: 5d412d0#diff-7ae5a9093507568eabbf35c3b0665732

But that is not what I get on npm install so 🤷‍♂

Thanks, it works.