ludocode / mpack

MPack - A C encoder/decoder for the MessagePack serialization format / msgpack.org[C]
MIT License
533 stars 82 forks source link

Code analysis #65

Closed nxrighthere closed 5 years ago

nxrighthere commented 5 years ago

I just performed code analysis using PVS-Studio, and the application detected up to 24 warnings with various levels.

Here's a beautiful and convenient HTML report for you: mpack_analysis.zip

nxrighthere commented 5 years ago

I believe that there are many false positive warnings, but still, maybe you will find something that deserves some attention.

ludocode commented 5 years ago

I had a quick look at the results and didn't see anything concerning. Some of these could be fixed to reduce false-positive warnings but I'm a bit uncomfortable with using proprietary static analysis tools. PVS-Studio has a strange rule requiring an advertisement comment to allow using it for free in open source projects and I'm not sure if they allow commercial users to analyze other projects and share the results. Thanks anyway though.