search

ludofleury / GuzzleBundle

Debug your API Calls with a Symfony web profiler for guzzle
http://ludofleury.github.io/GuzzleBundle/
MIT License
82 stars 21 forks source link

Silex provider #16

Open mtotheikle opened 11 years ago

mtotheikle commented 11 years ago

This pull requests allows integration to the guzzle data collector with Silex. Documentation on usage is slim right now and no tests have been done.

One thing that still needs to be done and needs discussion is how to load the font files that are needed since we can not use the "asset" filter.

ludofleury commented 11 years ago

I'm reviewing this asap, thanks a lot.

mtotheikle commented 11 years ago

Sounds good. Let me know your thoughts on loading of the fonts since we have to handle it a little differently with Silex based applications. It will probably require some configuration I'm thinking.

ludofleury commented 11 years ago

Actually I never used the web profiler from Symfony on Silex. I have to try first. But i guess i understand the prob the "bundle trivial feature" aren't provided by Silex, so the embedded assets aren't "magically" dumped right ? On Nov 15, 2013 12:54 AM, "Michael Williams" notifications@github.com wrote:

Sounds good. Let me know your thoughts on loading of the fonts since we have to handle it a little differently with Silex based applications. It will probably require some configuration I'm thinking.

— Reply to this email directly or view it on GitHubhttps://github.com/ludofleury/GuzzleBundle/pull/16#issuecomment-28535535 .

mtotheikle commented 11 years ago

Correct. This means that we don't know where these assets will live on the web server

ludofleury commented 10 years ago

Hey, so my question is: is this a common practice to include silex provider in a bundle ? I have a solution which is actually provide a post composer script to dump the assets in a configured path... But it would be extra hackish and since there is no hard convention in silex, it would require an user input.

The other solution is to actually separate this provider in another repo with a composer dependecy to this bundle. Then we could add a script/command to dump the assets.

mtotheikle commented 10 years ago

I'm not sure what the best practice is. As long as the other repo is referenced within this one so that developers easily see it exist I'm sure it would be fine to live on it's own.

ludofleury commented 10 years ago

Ok, let's do this. I'll reference it in the readme :+1:

ludofleury commented 10 years ago

Be aware that this bundle could be merged into this one: https://github.com/misd-service-development/guzzle-bundle/pull/29

mtotheikle commented 10 years ago

Great to see the merging of the bundles happening!