search

ludofleury / GuzzleBundle

Debug your API Calls with a Symfony web profiler for guzzle
http://ludofleury.github.io/GuzzleBundle/
MIT License
82 stars 21 forks source link

Support for Symfony 2.3 #8

Closed remialvado closed 11 years ago

remialvado commented 11 years ago

Hi,

since Symfony 2.3 has just landed, it is now required to update the composer.json to support it. I've changed it to support 2.1+ (~2.1.0) versions. Can you update it and tag a 1.0.0 version so that I can keep my minimum-stability to "stable" ? Thanks

ludofleury commented 11 years ago

Hey, so basically I'm not used to the "~" version, what does it means exactly ? >= 2.1

remialvado commented 11 years ago

I had a small doubt and I was right to have one : it should have been ~2.1 and not ~2.1.0 It tells composer that any non-major update is OK after 2.1 meaning that any 2.1., 2.2., 2.3.*, ... is allowed but 3.0.0 is not. It is better explained in composer documentation : http://getcomposer.org/doc/01-basic-usage.md#package-versions (under "Next Significant Release" section). Sorry for the confusion.

I've tested it while updating some of my applications to Symfony 2.3 and it works fine.

ludofleury commented 11 years ago

Very nice and well done. Do you need the stable version quickly ?

remialvado commented 11 years ago

No, it's fine by now : I've cheated by using the @dev annotation : 

"playbloom/guzzle-bundle": "dev-master@dev",
ludofleury commented 11 years ago

Hey @remialvado, I totally forgot this PR sorry. I just updated to accept Symfony 2.1 to 2.3, tell me if it's ok for you ?

Ok since I re-read your comment, maybe only ~2.1 is enough ?

remialvado commented 11 years ago

Yes, ~2.1 is enough. You can go with it :) Thanks

ludofleury commented 11 years ago

@remialvado ok done, thanks for your help !