Phrases in filter not working as expected

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Features selected (+options for each feature):
{"general_currdir":true,"general_pageicon":true,"general_counterinterval":"5","g
eneral_stats":true,"theme_externaltheme":"none","theme_color":"#565656","theme_b
g":"#FFC","theme_ncolumns":"2","theme_key_toggletheme":{"id":"toggletheme","titl
e":"Toggle 
theme","key":{"keyCode":88,"altKey":true}},"ig_randomtime":true,"ig_randomthemes
":"30","ig_key_toggletheme":{"id":"toggletheme","title":"Toggle 
theme","key":{"keyCode":89,"altKey":true}},"ig_key_random":{"id":"random","title
":"Random theme","key":{"keyCode":82,"shiftKey":true}},"relook_css":"/* This 
CSS sample alternates green entry, red border */\n/* green entry 
*/\n.entry:nth-child(even) .card-common, \n.entry:nth-child(even) 
.card-actions, \n#entries .entry:nth-child(even) .collapsed {\n border:1px 
solid #FFACAC;\n}\n/* red border */\n.entry:nth-child(odd) .card-common, 
\n.entry:nth-child(odd) .card-actions, \n#entries .entry:nth-child(odd) 
.collapsed {\n 
background-color:#C4DFC0;\n}\n","relook_key_toggletheme":{"id":"togglerelook","t
itle":"Toggle 
relook","key":{"keyCode":90,"altKey":true}},"favicons_cloud":true,"favicons_doma
ins":{},"removeads_links":"da.feedsportal.com|res.feedsportal.com|doubleclick.ne
t|/ads","removeads_images":"feedsportal.com|doubleclick.net|/ads","removeads_ifr
ames":"feedsportal.com|doubleclick.net|googlesyndication.com/pagead/ads","column
_count":"3","column_pagebreak":true,"column_miniparas":"5","column_key_columns":
{"id":"columns","title":"Multi 
columns","key":{"keyCode":67}},"preview_key_prview":{"id":"prview","title":"Entr
y preview","key":{"keyCode":81}},"preview_key_next":{"id":"next","title":"Next 
preview","key":{"keyCode":81,"shiftKey":true}},"preview_key_previous":{"id":"pre
vious","title":"Previous 
preview","key":{"keyCode":81,"ctrlKey":true}},"preview_key_close":{"id":"close",
"title":"Close 
preview","key":{"keyCode":88,"altKey":true}},"colorful_background":"#BCBCBC","co
lorful_color":"#000000","filter_excludes":"\"of the Day\" Apple Mac iPad iPod 
iPhone iOS \"OS X\"","filter_highlights":"Android RIP Lego Hackszine DIY 
LeConte \"Lovely Listing\"  Infographic \"Late Links\" \"Morning Links\" \"This 
x That\" \"Today on TDW:Geek\"  
\nRemains","facebook_key_gofacebook":{"id":"gofacebook","title":"Post on 
Facebook","key":{"keyCode":70}},"twitter_shortener":"tinyurl","twitter_key_tweet
":{"id":"tweet","title":"Post on 
Twitter","key":{"keyCode":87}},"instapaper_key_share":{"id":"share","title":"Rea
d Later with 
Instapaper","key":{"keyCode":73}},"readitlater_key_share":{"id":"share","title":
"Read Later with 
ReadItLater","key":{"keyCode":76}},"mark_key_markprev":{"id":"markprev","title":
"Mark items before As 
Read","key":{"keyCode":87,"shitKey":true}},"mark_key_marknext":{"id":"marknext",
"title":"Mark items after As 
Read","key":{"keyCode":89,"shitKey":true}},"jump_key_goup":{"id":"goup","title":
"Goto 
top","key":{"keyCode":84,"shiftKey":true}},"jump_key_godown":{"id":"godown","tit
le":"Goto 
bottom","key":{"keyCode":66,"shiftKey":true}},"fitheight_key_fit":{"id":"fit","t
itle":"Fit 
height","key":{"keyCode":72}},"closeentry_key_close":{"id":"close","title":"Clos
e 
entry","key":{"keyCode":88}},"openbackground_key_openback":{"id":"openback","tit
le":"Open in background 
tab","key":{"shiftKey":true,"keyCode":86}},"translate_lang":"en","translate_key_
translate":{"id":"translate","title":"Translate 
entry","key":{"keyCode":84,"altKey":true}},"limit_mini":"30","limit_maxi":"200",
"prefetch_first":"25","prefetch_next":"15","prefetch_list":"60","nested_separato
r":":","replacer_cloud":true,"filter":true,"removeads":true,"language_lang":"en"
,"filter_settings":{"hideExcluds":1,"hideDuplicates":1,"preferHighlights":1},"fi
lter_items":{"excludes":["Apple","Mac OS X Tip","Movie Trailer","Music 
Video","Photoshop","Popout","This Is Epic, You Should Listen To It","This Is 
Funny, You Should Watch It","Woot Weads The 
Wire","YouTube","iOS","iPad","iPhone","iTunes"],"highlights":["Android","DIY","I
nfographic","Late Links","Morning Links","This x That","Today On TDW: 
Geek","Lego"]},"preview_loading":true,"twitter_key_share":{"id":"share","title":
"Post on 
Twitter","key":{"keyCode":87}},"identi_shortener":"googl","identi_key_share":{"i
d":"share","title":"Post on 
Identi.ca","key":{"keyCode":87,"shiftKey":true}},"radbox_key_share":{"id":"share
","title":"Read Later with 
Radbox","key":{"keyCode":66}},"addthis_layout":"button_classic","addthis_key_sha
re":{"id":"share","title":"Share with 
Addthis","key":{"keyCode":66,"ctrlKey":true}},"blogger_key_share":{"id":"share",
"title":"Share with 
Blogger","key":{"keyCode":66,"altKey":true}},"filter_hide_duplicates":true,"filt
er_prefer_highlights":true,"filter_live":true,"filter_word_mini":"3","general_hi
detoolbar":true,"filter_detect_duplicates":true,"filter_button":true}

2. Url feed:
http://feeds.feedburner.com/feedburner/oicv
http://lifehacker.com/vip.xml

3/4. What is the expected output?/What do you see instead?
On Lifehacker, a post titled "It's World Backup Day: Here's How to Avoid 
Inevitable Disasters [Backup]" is being excluded, when it should not
If I add "Remains of the Day" to my highlights instead of Remains, all of the 
"of the Day" posts in TDW stop being excluded.

What is your version of GoogleReaderPlus ?
->3.6.1

What version of the product are you using?  (copy/paste from about:version
+ preferences/SysInfo)

Chrome (+channel):
Screen resolution:1600x1200
SysInfo:

On what operating system - Windows(XP, Vista...), Linux(Ubuntu, Debian...), XP 
SP3
MacOs(9, X...)?

Which others extensions are installed ?
AdBlock Plus
Add to Amazon Wishlist
Better Facebook
Chrome Toolbox
Clickable Links
Docs PDF/Powerpoint Viewer
Facebook Ad Block
Keep My Opt-Outs
LastPass
Personal Blocklist
WidgetBlock

Please provide any additional information below:
Either the filters don't work "as advertised," or I don't understand them from 
the information given.  The description of the filters in the FAQ makes them 
seem like putting spaces between words and putting them on the same line are 
the same, but it's not.  Putting things in quotes does not seem to work 
correctly--I think it's treating each word individually.

Original issue reported on code.google.com by bitba...@gmail.com on 31 Mar 2011 at 3:04

[GoogleCodeExporter]

Yes, you re right, there is a bug on quoted strings!

Original comment by ludovic.valente on 5 Apr 2011 at 11:26

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by ludovic.valente on 5 Apr 2011 at 11:26

• Added labels: Feature-Filter

[GoogleCodeExporter]

Fixed !
I escaped only the first space!

Original comment by ludovic.valente on 5 Apr 2011 at 11:29

• Changed state: Fixed
• Added labels: Milestone-v3.6.3

[GoogleCodeExporter]

Original comment by ludovic.valente on 5 Apr 2011 at 11:30

• Added labels: Milestone-v3.6.2
• Removed labels: Milestone-v3.6.3

[GoogleCodeExporter]

and squares [] were badly parsed !

Original comment by ludovic.valente on 5 Apr 2011 at 12:20

[GoogleCodeExporter]

I'm a little bit confused:

One of Issue 400's emails stated:
"Labels: -Milestone-v3.6.3 Milestone-v3.6.2"

I noted 362beta1 in the downloads section. Should I wait for 363betaX for the 
fix?

Thanks,

Mike

Original comment by mrmar...@gmail.com on 5 Apr 2011 at 12:42

[GoogleCodeExporter]

I just uploaded this version for account menu (signin/signout).
but filter updates (including #400) should be already inside !

Original comment by ludovic.valente on 5 Apr 2011 at 1:40

[GoogleCodeExporter]

Hmm.  Just tried 362 beta 2, and it's still not working the way I expect.  If I 
look at     
http://news.blogs.cnn.com/feed/ 
with exclude filter
"of the Day" Video Apple Mac iPad iPod iPhone iOS "OS X" "Early Bird Special" 
"Morning Fluff" "Lights Out" "Afternoon Snack"
it's excluding every post containing the word "day."

Am I using it wrong?

Original comment by bitba...@gmail.com on 5 Apr 2011 at 3:18

[GoogleCodeExporter]

Same thing seems to be happening with highlights.

I tried highlighting the term Droid X (on its own line with no quotes). 
Highlighted every post including the words android or any word with the letter 
X.

If I put quotes around "Droid X", it found nothing, though many posts had the 
term Droid X in the title.

Ouch!

Original comment by mrmar...@gmail.com on 5 Apr 2011 at 3:21

[GoogleCodeExporter]

Original comment by ludovic.valente on 6 Apr 2011 at 2:18

• Changed state: Accepted

[GoogleCodeExporter]

I work on expression parsing.
I've got a good start :
- Each line is an expression
- An expression is composed of terms
- Each term are separated with a space and ALL terms should match (space=AND -> 
this is major change vs current version)
- A term is single word or a quoted epxression
- A term could be started  with a keyword like author: date:

I prepare the beta for testing !

Original comment by ludovic.valente on 14 Apr 2011 at 7:24

[GoogleCodeExporter]

beta3 available, please try it and give me feedback !

Expressions should be more useful like this...

Original comment by ludovic.valente on 14 Apr 2011 at 9:49

• Changed state: Verified

[GoogleCodeExporter]

Filtering is working better now!  :-D Term "Droid X" (with quotes) is 
highlighting now, and not everything with either droid or x as before.

However...

Colorful listview now appears broken... :-(

I have colorful listview checked, but the colors aren't rendering. Maybe 
something to do with the way highlights are displayed? Problem persists whether 
filtering is off or on.(This is important, on some of the monitors I use this 
on, the colors help drop the glare...)

Thanks!

Mike

Original comment by mrmar...@gmail.com on 14 Apr 2011 at 2:48

[GoogleCodeExporter]

how fast you are :) great !!

yes, you're right ! 
but this is a separate issue !
look and will be fixed!

Original comment by ludovic.valente on 14 Apr 2011 at 2:58

[GoogleCodeExporter]

Ludovic,
DEFINITE improvement!
Had to use "Mac " to keep it from excluding a title including the word "machine"
Didn't try regular expressions yet.

What are all the keywords?

Original comment by bitba...@gmail.com on 14 Apr 2011 at 3:22

[GoogleCodeExporter]

not clear ! did you try to do a "machine -mac" like ?
-> NOT operator is still not done !

keywords are : 
author
tag
date
feed

values should match as regex string (especially for date , because depending on 
locale using datatype is harder)

if you understand code you could still have a look here :
http://code.google.com/p/googlereaderplus/source/browse/trunk/GoogleReaderPlus/s
rc/filter.js#556

Original comment by ludovic.valente on 15 Apr 2011 at 7:19

[GoogleCodeExporter]

Ludovic,
I was trying to exclude "Mac" (as in Macintosh), but when I just put "Mac", it 
also excluded posts with the word "machine".  When I put it in quotes and added 
the space, that got it to stop.

Original comment by bitba...@gmail.com on 15 Apr 2011 at 1:40

[GoogleCodeExporter]

ok i understand!
i think i will use word boundary /b regex to delimit a quoted terms!

so mac will match mac and macintosh
since "mac" should match mac only

Original comment by ludovic.valente on 18 Apr 2011 at 7:44