search

ludorival / vscode-preview-jsdoc

VSCode extension to automatically preview the generated jsdoc
MIT License
6 stars 1 forks source link

Live reload box doesn't put line breaks #33

Closed Abrifq closed 4 years ago

Abrifq commented 4 years ago

It just puts a <br>. I think you used innerText. I 'hotfixed' it by changing innerText to innerHTML but it can also be done by putting a line break (\n) instead of <br/>

Another apporach would be making it added as a pre instead of span, getting rid of line breaks.

I am currently testing the script by injecting it to the extension directly.

Abrifq commented 4 years ago

FYI, I have already created a fork, ready to merge.

Abrifq commented 4 years ago

Closing this "issue" for now due to inactivity.

ludorival commented 4 years ago

Hi @fbarda, I am not sure to understand, is this something you've already fixed? Why do you not suggest a pull request as you did before ?

FYI, I have already created a fork, ready to merge.

Abrifq commented 4 years ago

@ludorival I did a fork now. I was busy to make a proper commit before.

ludorival commented 4 years ago

Thanks @fbarda I integrated your change in the 2.0.9 version