Interferes with Obsidian quitting

ludovicchabant / obsidian-remember-file-state

A plugin for Obsidian that remembers cursor position, selection, scrolling, and more for each file.

MIT License

49 stars 1 forks source link

Interferes with Obsidian quitting #22

Open JoggledMind opened 10 months ago

JoggledMind commented 10 months ago

Running Obsidian insider builds 1.5.1 and 1.5.2, found that when I cmd-q Obsidian, the app did not completely quit. Would fully quit only with forced quit command. Working with kepano, I disabled all plugins and added them back one at a time to replicate the problem. When I reenabled Remember File State, the proclem recurred. Disabled it, problem went away. At kepano's request, I'm notifying you of the issue. Thanks.

claremacrae commented 10 months ago

@JoggledMind I'm not involved in this plugin, but as a developer, if you can add info about the following, it's likely to increase the chances of someone being able to investigate this...

What platform you are running on
How someone is supposed to be able to identify that Obsidian is still running on that platform...

claremacrae commented 10 months ago

Also, @JoggledMind, what version of this plugin you were running....

claremacrae commented 10 months ago

@ludovicchabant - if you don't have access to Obsidian Insider builds and would like it, perhaps to help with this issue, I am happy to gift you an Insider Subscription...

Email me via the address in my GitHub profile...

claremacrae commented 10 months ago

This may be relevant:

ludovicchabant commented 10 months ago

Hi! I have 1.5.2 currently and I don't see any problem. When you say that the app doesn't completely quit, do you mean it's still open even after pressing Cmd-Q, or do you mean it disappeared but the process continues in the background, or something else?

LFSaw commented 7 months ago

I experience the same problem:

When quitting Obsidian with CMD-Q, all windows are closed but the app is still open (Menubar continues to have an Obsidian app without any windows). Hitting CMD-Q again then closes the app.

Obsidian Version 1.5.11 (Installer 1.4.16), plugin Version: 1.1.2 (currently installed: 1.1.2) on

$ system_profiler SPSoftwareDataType SPHardwareDataType
Software:

    System Software Overview:

      System Version: macOS 13.6.3 (22G436)
      Kernel Version: Darwin 22.6.0
      [...]
Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro14,2
      Processor Name: Dual-Core Intel Core i5
[...]

but also on

$ system_profiler SPSoftwareDataType SPHardwareDataType
Software:

    System Software Overview:

      System Version: macOS 13.6.3 (22G436)
      Kernel Version: Darwin 22.6.0

Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro18,3
      Model Number: Z15G002EZD/A
      Chip: Apple M1 Pro
[...]

sambody commented 2 months ago

Same problem here. I need to do Cmd-Q twice to really quit the app.

And when I do a restart of my machine, the closing down of my Mac session is blocked because Obsidian doesn't want to close with a single call.

When I deactive the extension, all is well.