search

ludrao / django-tellme

Django app that enable user feedback (feedback button)
Other
152 stars 51 forks source link

AttributeError: 'WSGIRequest' object has no attribute 'is_ajax' #82

Open NiklasMerz opened 2 years ago

NiklasMerz commented 2 years ago

I get this error with Django 4.x. Can we safely remove this check?

From Django release notes

The HttpRequest.is_ajax() method is deprecated as it relied on a jQuery-specific way of signifying AJAX calls, while current usage tends to use the JavaScript Fetch API. Depending on your use case, you can either write your own AJAX detection method, or use the new HttpRequest.accepts() method if your code depends on the client Accept HTTP header.

NiklasMerz commented 2 years ago

Sorry there is already PR #80 for that.

Moring commented 1 year ago

See https://github.com/ludrao/django-tellme/issues/81