search

ludvigak / FINUFFT.jl

Julia interface to the nonuniform FFT library FINUFFT
Other
33 stars 9 forks source link

Keep references to input arrays in guru plan struct #40

Closed ludvigak closed 2 years ago

ludvigak commented 2 years ago

This should hopefully avoid segfault due to users not knowing exactly how the memory management works under the hood.

Fixes #39

codecov[bot] commented 2 years ago

Codecov Report

Merging #40 (4568f59) into master (f935efa) will increase coverage by 0.35%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   89.70%   90.05%   +0.35%     
==========================================
  Files           3        3              
  Lines         340      352      +12     
==========================================
+ Hits          305      317      +12     
  Misses         35       35
Impacted Files Coverage Δ
src/guru.jl 86.99% <100.00%> (+1.40%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f935efa...4568f59. Read the comment docs.

tknopp commented 2 years ago

Just tested this branch and can confirm, this fixes #39!