search

ludvigak / FINUFFT.jl

Julia interface to the nonuniform FFT library FINUFFT
Other
33 stars 9 forks source link

Remove redundant checks whereever possible #47

Closed jkrimmer closed 4 months ago

jkrimmer commented 2 years ago

Take care of #46 .

codecov[bot] commented 2 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.77%. Comparing base (d987944) to head (24e280e). Report is 4 commits behind head on master.

:exclamation: Current head 24e280e differs from pull request most recent head a73b437

Please upload reports for the commit a73b437 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #47 +/- ## ========================================== - Coverage 89.94% 89.77% -0.18% ========================================== Files 3 3 Lines 358 352 -6 ========================================== - Hits 322 316 -6 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahbarnett commented 2 years ago

FWIW I tested your 3.1.0 now on master, and the tests and examples are all good on my julia 1.7 linux laptop. Thanks for that! Alex

ludvigak commented 2 years ago

Sure, no reason not to simplify. Seems to be a merge conflict at the moment though

jkrimmer commented 2 years ago

Good point, I will work on the conflicts later today

ludvigak commented 4 months ago

Merging stale PR