ludviglundgren / qbittorrent-cli

Cli to manage qBittorrent
MIT License
158 stars 17 forks source link

Failed test #44

Closed folliehiyuki closed 1 year ago

folliehiyuki commented 1 year ago

Another blocker on my packaging process.

$ go test ./...
# github.com/ludviglundgren/qbittorrent-cli/cmd [github.com/ludviglundgren/qbittorrent-cli/cmd.test]
cmd/export_test.go:30:99: too many arguments in call to processHashes
    have (string, string, map[string]struct{}, []string, bool)
    want (string, string, map[string]struct{}, bool)
FAIL    github.com/ludviglundgren/qbittorrent-cli/cmd [build failed]
?       github.com/ludviglundgren/qbittorrent-cli/cmd/qbt   [no test files]
?       github.com/ludviglundgren/qbittorrent-cli/internal/config   [no test files]
?       github.com/ludviglundgren/qbittorrent-cli/internal/domain   [no test files]
?       github.com/ludviglundgren/qbittorrent-cli/internal/fs   [no test files]
?       github.com/ludviglundgren/qbittorrent-cli/pkg/qbittorrent   [no test files]
?       github.com/ludviglundgren/qbittorrent-cli/pkg/torrent   [no test files]
2023/03/12 15:43:12 Total torrents to process: 2
2023/03/12 15:43:12 os create error: open ../../test/output/deluge/3eced34cd948e7ea92f31ded3e0fd734274fee4a.fastresume: no such file or directory
2023/03/12 15:43:12 Could not create qBittorrent fastresume file ../../test/output/deluge/3eced34cd948e7ea92f31ded3e0fd734274fee4a.fastresume error: "open ../../test/output/deluge/3eced34cd948e7ea92f31ded3e0fd734274fee4a.fastresume: no such file or directory"
--- FAIL: TestDelugeImport_Import (0.00s)
    --- FAIL: TestDelugeImport_Import/import_from_deluge (0.00s)
        deluge_test.go:25: Import() error = open ../../test/output/deluge/3eced34cd948e7ea92f31ded3e0fd734274fee4a.fastresume: no such file or directory, wantErr false
--- FAIL: TestRTorrentImport_Import (0.00s)
    --- FAIL: TestRTorrentImport_Import/import_from_rtorrent (0.00s)
        rtorrent_test.go:27: Import() error = Directory does not exist: ../../test/import/sessions/: stat ../../test/import/sessions/: no such file or directory, wantErr false
FAIL
FAIL    github.com/ludviglundgren/qbittorrent-cli/internal/importer 0.005s
FAIL
ludviglundgren commented 1 year ago

While it's not a good solution, nor a band-aid fix, ignore these until they are fixed.

They require some data that is missing from the repo.

folliehiyuki commented 1 year ago

While you are at it, maybe also updating go.mod?

ludviglundgren commented 1 year ago

@FollieHiyuki Sorry for the delay, will update the deps and do something about the tests!

folliehiyuki commented 1 year ago

Thanks! I can see that the tests passed now. Also noticed the dependencies update.

Is there any plans to migrate away from github.com/pkg/errors? That's the only blocker left in my request.