search

ludviglundgren / vscode-stockholm-theme

A theme for Visual Studio Code inspired by Sandbox.io.
https://marketplace.visualstudio.com/items?itemName=LudvigLundgren.StockholmTheme
MIT License
9 stars 4 forks source link

Some issues #1

Closed MioQuispe closed 6 years ago

MioQuispe commented 6 years ago

Hey there, lovely theme! I encountered a few issues with it though, look at the props as well as jsx elements: image

ludviglundgren commented 6 years ago

Hello! Thanks!

The first release was a quite naive implementation, and i should probably redo some of the stuff. Do you have any suggestions how to make it look better?

jcuadrad commented 6 years ago

@ludviglundgren I do have the question of why the JSX elements are Yellow, instead of Red like codesandobx.io, is this by design or for a reason I should understand?

Awesome theme!

ludviglundgren commented 6 years ago

Thanks @jcuadrad!

Well thats very weird, this is how it looks for me with the same code as above. image

It is not 100% like the codesandbox theme, and theres a couple of things that could be better which I will fix when theres time.

The only thing i can think of is that i have this extension for better syntax highlighting of es6/7 etc. https://github.com/dzannotti/vscode-babel/

Could you try that and see what happens? If that's it i'll have to include it in the readme 👍

taoeer commented 6 years ago

I had same issue!But but gone when i installed the 'vscode-babel'!