Improve ludwig feature dict

ludwig-ai / ludwig

Low-code framework for building custom LLMs, neural networks, and other AI models

http://ludwig.ai

Apache License 2.0

11.19k stars 1.19k forks source link

Improve ludwig feature dict #3904

Open dennisrall opened 10 months ago

dennisrall commented 10 months ago

Some minor improvements to the LudwigFeatureDict:

remove strange __next__ method
remove internal_key_to_original_name_map dict as the values were never read
use MutableMapping from the collections.abc → get useful and more performant methods
added tests for the new functionality and split up the old test (I kept the old test to show it is still running, but I think it can be removed?)

github-actions[bot] commented 10 months ago

Unit Test Results

  4 files -   2   4 suites - 2 2m 58s :stopwatch: - 11m 42s 12 tests ±  0   6 :heavy_check_mark: -   3   5 :zzz: +2 1 :x: +1 40 runs - 20 16 :heavy_check_mark: - 26 20 :zzz: +2 4 :x: +4

For more details on these failures, see this check.

Results for commit acfa1984. ± Comparison against base commit 0a24d0ae.

This pull request skips 2 tests.

``` tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml] tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml] ```

:recycle: This comment has been updated with latest results.

mhabedank commented 4 weeks ago

LGTM can be merged as soon as possible