Add unit tests for image utils unet functions

ludwig-ai / ludwig

Low-code framework for building custom LLMs, neural networks, and other AI models

http://ludwig.ai

Apache License 2.0

11.21k stars 1.19k forks source link

Add unit tests for image utils unet functions #3921

Closed vijayi1 closed 9 months ago

vijayi1 commented 10 months ago

This is a follow up to PR 3913. It adds unit tests for the image utils functions added by that PR.

github-actions[bot] commented 10 months ago

Unit Test Results

  4 files ±0   4 suites ±0 9m 14s :stopwatch: - 2m 55s 12 tests ±0   7 :heavy_check_mark: - 2   5 :zzz: +2 0 :x: ±0 40 runs ±0 20 :heavy_check_mark: - 8 20 :zzz: +8 0 :x: ±0

Results for commit 340eb699. ± Comparison against base commit 6723a30c.

This pull request skips 2 tests.

``` tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml] tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml] ```

:recycle: This comment has been updated with latest results.

justinxzhao commented 10 months ago

The regression tests are flaky, however it looks like there's another dependency issue going on with torch nightly.

vijayi1 commented 9 months ago

@arnavgarg1 sure. can you please confirm if the following steps are correct to rebase a PR and make additional changes (if needed),

To rebase my branch: git fetch upstream git rebase upstream/master

To make further code changes: git add . git commit git push -u origin unet-image-utils-tests

arnavgarg1 commented 9 months ago

@vijayi1 I think that mostly looks correct! I would change the ordering of the steps to be this instead:

git fetch upstream
git checkout unet-image-utils-tests (you want to make sure you're on your branch)
git rebase upstream/master (rebase onto your branch)

Followed by: git add . git commit -m git push -u origin unet-image-utils-tests

vijayi1 commented 9 months ago

@arnavgarg1, I followed those steps exactly and got the following error during push,

(dl_venv) [vijayi@sparky01 ludwig]$ git push -u origin unet-image-utils-tests To github.com:vijayi1/ludwig.git ! [rejected] unet-image-utils-tests -> unet-image-utils-tests (non-fast-forward) error: failed to push some refs to 'github.com:vijayi1/ludwig.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details. (dl_venv) [vijayi@sparky01 ludwig]$

arnavgarg1 commented 9 months ago

@vijayi1 I see. Okay, if you abort the rebase, another option is to just pull the latest master and merge it into your branch - it should achieve roughly the same effect?

vijayi1 commented 9 months ago

@arnavgarg1, merge completed and I added a few description changes for the docs. the utils tests passed.