ludwig-ai / ludwig

Low-code framework for building custom LLMs, neural networks, and other AI models
http://ludwig.ai
Apache License 2.0
11.21k stars 1.19k forks source link

Re-Enable AdaptionPrompt when HuggingFace releases the PEFT fix. #3938

Closed alexsherstinsky closed 1 month ago

alexsherstinsky commented 9 months ago

Describe the bug On 02/21/2024, we had to disable AdaptionPrompt because of this error:

TypeError: LlamaRotaryEmbedding.forward() missing 1 required positional argument: 'position_ids')

which was traced to PEFT incompatibility.

To Reproduce Steps to reproduce the behavior:

  1. Run pytest --cache-clear --full-trace -k "adaption_prompt-defaults" tests/integration_tests/test_llm.py::test_llm_finetuning_strategies -svv
  2. Run pytest --cache-clear --full-trace tests/integration_tests/test_llm.py::test_load_pretrained_adapter_weights -svv
  3. See errors

Please provide code, yaml config file and a sample of data in order to entirely reproduce the issue. Issues that are not reproducible will be ignored.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.