Scope

We must pin matplotlib to "<3.9.0", because the latter (released on 5/15/2024), cause API incompatibilities:

-------- generated xml file: /home/runner/work/ludwig/ludwig/pytest.xml --------
=========================== short test summary info ============================
ERROR tests/integration_tests/test_visualization.py - AttributeError: module 'matplotlib.cm' has no attribute 'register_cmap'
ERROR tests/integration_tests/test_visualization_api.py - AttributeError: module 'matplotlib.cm' has no attribute 'register_cmap'
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!
==== 2 skipped, 4[93](https://github.com/ludwig-ai/ludwig/actions/runs/9151376924/job/25157299861?pr=3981#step:7:94)3 deselected, 2 warnings, 2 errors in 357.57s (0:05:57) =====
Error: Process completed with exit code 2.

thus breaking the tests collection. Pinning the version of matplotlib fixes this issue. We will keep an eye on the future matplotlib releases, which might render the pinning of its version unnecessary.

We also fix the ViTEncoder to ensure that the transformers.ViTModel returns the output_attentions.

Code Pull Requests

Please provide the following:

a clear explanation of what your code does
if applicable, a reference to an issue
a reproducible test for your PR (code, config and data sample)

Documentation Pull Requests

Note that the documentation HTML files are in docs/ while the Markdown sources are in mkdocs/docs.

If you are proposing a modification to the documentation you should change only the Markdown files.

api.md is automatically generated from the docstrings in the code, so if you want to change something in that file, first modify ludwig/api.py docstring, then run mkdocs/code_docs_autogen.py, which will create mkdocs/docs/api.md .

ludwig-ai / ludwig

[MAINTENANCE] Most Recent Version of matplotlib breaks ptitprince and seaborn method calls. #4007

Scope

Code Pull Requests

Documentation Pull Requests

Unit Test Results