search

ludwig-cf / ludwig

A lattice Boltzmann code for complex fluids
https://ludwig.epcc.ed.ac.uk
Other
52 stars 35 forks source link

Applied fbody on colloid sites #279

Closed ohenrich closed 10 months ago

ohenrich commented 1 year ago

Hi Kevin,

This is the fix that you said should go with the rest of the current development. The error becomes apparent when a colloid is in large confinement (small duct). The results agree very well with M.E. Staben et al., Phys. Fluids 15, 1711 (2003).

I will prepare a test case in due course.

codecov[bot] commented 1 year ago

Codecov Report

Merging #279 (b613d18) into feature-ellipsoid (c679029) will increase coverage by 0.26%. The diff coverage is 0.00%.

@@                  Coverage Diff                  @@
##           feature-ellipsoid     #279      +/-   ##
=====================================================
+ Coverage              30.42%   30.69%   +0.26%     
=====================================================
  Files                    184      184              
  Lines                  35494    34898     -596     
  Branches                 951      888      -63     
=====================================================
- Hits                   10799    10711      -88     
+ Misses                 24517    24009     -508     
  Partials                 178      178
Files Changed Coverage Δ
src/interaction.c 25.97% <0.00%> (-0.70%) :arrow_down:

... and 2 files with indirect coverage changes

kevinstratford commented 10 months ago

I've put in an issue #285 on this, and will come forward with a new pull request.